Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use a mask for the continuation icon #2737

Merged
merged 2 commits into from
Mar 2, 2019
Merged

Conversation

turt2live
Copy link
Member

@turt2live turt2live requested a review from a team March 1, 2019 23:00
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😁 A small nit about element, but otherwise looks great!

@@ -53,7 +53,7 @@ module.exports = React.createClass({
permalinkCreator.load();
const predecessorPermalink = permalinkCreator.forEvent(predecessor['event_id']);
return <div className="mx_CreateEvent">
<img className="mx_CreateEvent_image" src={require("../../../../res/img/room-continuation.svg")} />
<img className="mx_CreateEvent_image" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it should just be a div or something since it no longer loads an image itself?

There's no source, so just make it a block element
@turt2live turt2live merged commit ead73ee into develop Mar 2, 2019
@turt2live turt2live deleted the travis/continuation-icon branch March 2, 2019 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants