Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use getRelation helper #2977

Merged
merged 1 commit into from
May 16, 2019
Merged

Use getRelation helper #2977

merged 1 commit into from
May 16, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented May 15, 2019

Use the getRelation helper to ensure we always read relation info from the
wire content as required in E2E rooms.

This is part of element-hq/element-web#9672 to show reactions in E2E rooms.

@jryans jryans requested a review from a team May 15, 2019 16:29
@turt2live turt2live self-requested a review May 15, 2019 17:30
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to throw a HACK or XXX on the replies comment

Use the `getRelation` helper to ensure we always read relation info from the
wire content as required in E2E rooms.
@jryans jryans force-pushed the jryans/encrypted-reactions branch from 87e8827 to 33885cb Compare May 16, 2019 08:25
@jryans
Copy link
Collaborator Author

jryans commented May 16, 2019

would be good to throw a HACK or XXX on the replies comment

Okay, added.

@jryans jryans merged commit 0e369bd into develop May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants