This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix: latin input through Chinese IME #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on of the 2 changes (updating dom async from compositionend, or ignoring keydown while composing) here has, while fixing chrome, broken safari. Don't do the async dom updating for safari if that was it.
jryans
approved these changes
Sep 25, 2019
| // checking the event.isComposing flag just in case any browser out there | ||
| // emits events related to the composition after compositionend | ||
| // has been fired | ||
| return !!(this._isIMEComposing || event.isComposing); |
There was a problem hiding this comment.
I think you may need to check event.nativeEvent? I think React doesn't include it in their synthetic events today: facebook/react#13104
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix element-hq/element-web#10913