Standardise on top margin for settings tabs

[sahilsaini1107]

Fixes element-hq/element-web#20767

Signed-off-by: Sahil saini [email protected]

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• changes top margin in settings tab. (#7727). Fixes Standardise on top margin for settings tabs element-hq/element-web#20767. Contributed by @sahilsaini110.

[SimonBrandner]

Could you please add the following to the description

Fixes https://github.com/vector-im/element-web/issues/20767

and change the PR's name to something more descriptive as it will be a part of the changelog?

[SimonBrandner]

Could this be somehow applied more globally instead of adding the code to each file? Some tabs also seem to have other than 10px padding or no padding, does this PR somehow fix those?

[sahilsaini1107]

Could this be somehow applied more globally instead of adding the code to each file? Some tabs also seem to have other than 10px padding or no padding, does this PR somehow fix those?

okay i will check that and get back to you.

[sahilsaini1107]

Could this be somehow applied more globally instead of adding the code to each file? Some tabs also seem to have other than 10px padding or no padding, does this PR somehow fix those?

may you please brief me which tabs are you talking about?

[SimonBrandner]

Could this be somehow applied more globally instead of adding the code to each file? Some tabs also seem to have other than 10px padding or no padding, does this PR somehow fix those?

may you please brief me which tabs are you talking about?

Some tabs (e.g. notifications) have margin other than 10 px (e.g. 24 px), how does setting the margin to 10 px fix this? Does it override some other CSS?

It's not clear to me how setting the margin to 10 px in some tabs fixes the problem, perhaps I am missing something?

[germain-gg]

To progress this pull request forward it would be great to have a similar screenshot to what was added to the original issue to see the before/after.

All the comments made by @SimonBrandner are also relevant, and generally speaking those styling rules should be applied more globally if we want to have more consistent spacing over time

I will request a design review once you have updated us with the screenshots

[sahilsaini1107]

Add

okay i will try to apply css globally. and also provide you the screenshots