Device manager - logout of other session (PSG-744)

[kerryarchibald]

Screen.Recording.2022-09-14.at.14.19.56.mov

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Device manager - logout of other session

---

Here's what your changelog entry will look like:

✨ Features

• Device manager - logout of other session (#9280). Contributed by @kerryarchibald.

[weeman1337]

@kerryarchibald in the video: why do you have to enter your password twice? Shouldn't there not be a cache with timeout preventing this?

[kerryarchibald]

@weeman1337, i guess the video is a bit confusing, the first time I fill the password then click outside the modal to cancel the interactive auth/deletion without submitting
you don't have to complete interactive auth twice in a row if it's submitted + succeeds

[t3chguy]

Shouldn't there not be a cache with timeout preventing this?

Also the client shouldn't be caching passwords, its up to the server to have a UIA cooldown (like Synapse does)

[weeman1337]

Tested on the deployment. Works 👍

Only some minor comments to improve code (read|main)tainability

[weeman1337]

We could avoid the fragment by replacing   with gap in .mx_DeviceDetails_signOutButtonContent

[weeman1337]

Uff. This is hard to read. Maybe we could improve this

• remove comments and hope people are using editors with param naming support or
• write each param on a line on its own and add the comment to the end {}, // props

[weeman1337]

Instead of using snapshots I would suggest

Suggested change

	expect(getByTestId('device-detail-sign-out-cta')).toMatchSnapshot();
	expect(getByTestId('device-detail-sign-out-cta')).toBeDisabled();

Then we only test the disabled state and not the entire button.

[weeman1337]

Like at the other place: would be nice to check specific attributes instead of the entire snapshot.