Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixes empty content type during upload #9847

Closed
wants to merge 2 commits into from
Closed

Fixes empty content type during upload #9847

wants to merge 2 commits into from

Conversation

K3das
Copy link
Contributor

@K3das K3das commented Dec 29, 2022

fixes #element-web/24119

By default a Blob has a empty string as a content type, so that type ends up being used as the request content type - causing encrypted uploads to also have have a empty content type.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Fixed empty Content-Type for encrypted uploads

Signed-off-by: Mia Pigal [email protected]


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@K3das K3das requested a review from a team as a code owner December 29, 2022 22:15
@github-actions
Copy link

Thanks for opening this pull request, unfortunately we do not accept contributions from the main branch of your fork, please re-open once you switch to an alternative branch for everyone's sanity. See https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Dec 29, 2022
@github-actions github-actions bot closed this Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Type header is bogus on encrypted uploads, should be application/octet-stream or similar
1 participant