Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

get_mentions_state() implemented on the Rust side (only for users and @room) #849

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 18, 2023

Implemented and exposed a function to get the current state of mentions in RTE.
This will allow us to efficiently get the current state of mentions, which might be very useful for intentional mentions.

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0663938) 87.79% compared to head (9b1b07b) 89.40%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #849      +/-   ##
============================================
+ Coverage     87.79%   89.40%   +1.61%     
============================================
  Files           161       84      -77     
  Lines         18562    15193    -3369     
  Branches        976        0     -976     
============================================
- Hits          16296    13583    -2713     
+ Misses         2013     1610     -403     
+ Partials        253        0     -253     
Flag Coverage Δ
uitests ?
uitests-android ?
uitests-ios ?
unittests 89.40% <62.85%> (+3.36%) ⬆️
unittests-android ?
unittests-ios ?
unittests-rust 89.40% <62.85%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
bindings/wysiwyg-ffi/src/lib.rs 0.00% <ø> (ø)
crates/wysiwyg/src/dom/iter.rs 87.76% <100.00%> (+0.07%) ⬆️
crates/wysiwyg/src/dom/nodes/dom_node.rs 88.26% <100.00%> (+0.10%) ⬆️
crates/wysiwyg/src/mentions_state.rs 100.00% <100.00%> (ø)
bindings/wysiwyg-ffi/src/ffi_composer_model.rs 26.92% <0.00%> (-0.27%) ⬇️
crates/wysiwyg/src/composer_model/mentions.rs 79.83% <82.35%> (+0.42%) ⬆️
bindings/wysiwyg-ffi/src/ffi_mentions_state.rs 0.00% <0.00%> (ø)

... and 79 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a few comments

crates/wysiwyg/src/composer_model/mentions.rs Outdated Show resolved Hide resolved
crates/wysiwyg/src/mentions_state.rs Outdated Show resolved Hide resolved
crates/wysiwyg/src/tests/test_mentions.rs Outdated Show resolved Hide resolved
crates/wysiwyg/src/tests/test_mentions.rs Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Velin92 Velin92 merged commit 9d60d40 into main Oct 19, 2023
@Velin92 Velin92 deleted the mauroromito/get_mentions_state branch October 19, 2023 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSC 3952: Intentional mentions support, expose an API to get current mentions in RTE
3 participants