-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dependencies breaks generated TypeScript #161
Comments
possibly we can work around this by post-processing the generated typescript, but that is clearly an unsatisfactory solution :/ |
I strongly suspect that the dependency update causing the change is the |
Ah, it looks like this is caused by rustwasm/wasm-bindgen#4207 or at least very closely related. |
So we should stay on wasm-bindgen v0.2.93 until rustwasm/wasm-bindgen#4207 is fixed. |
If I am using Rust 1.82.0 and run a
cargo update
then I get this error:Reading around this, it looks like some change in the dependencies causes this version of rustc¹ to use bulk memory operations in the generated wasm.
¹ Before I upgraded to rustc 1.82.0 it all actually built fine with no errors, but staying on an old rustc version doesn't seem viable.
If I enable bulk memory operations in wasm-opt by doing:
Then the build works OK but linting the generated TypeScript fails:
It looks like this lint is correctly identifying invalid/incomplete TypeScript being emitted (by wasm-bindgen?).
So we are unable to update our dependencies until we can fix this problem.
The text was updated successfully, but these errors were encountered: