Voice message support

[aviraldg]

autoplay in m.audio and m.recording event (required for element-hq/element-web#1358)

Generalizing the m.typing event instead may be a better idea.

[matrixbot]

Can one of the admins verify this patch?

[ara4n]

sorry for the delay on vetting this :(

I like the autoplay flag - I'm less certain about a whole new typing notification event in the form of m.recording. Typing notifs are already heavily special-cased both on servers & clients, and telling everyone they have to special case another event type there too is going to cause needless pain. I'm wondering if we can mux the info intom.typing instead... @erikjohnston any thoughts on this?

[aviraldg]

Right, I felt the ame.

Generalizing the m.typing event instead may be a better idea.

[aviraldg]

In general, in contet of thi and alo m.audio/m.file, I think a better olution i needed for derived event.

Broken keyboard 😢

[richvdh]

@ara4n do you have the conn on this or do you want me to take a look?

[aviraldg]

@ara4n Any updates on this?

[ara4n]

can we just slap it as an optional field on m.typing? i don't think it needs fullblown derived events...

[aviraldg]

@ara4n looks good to go?

[kegsay]

Be explicit please.

If true, this indicates that the audio should start playing automatically. If false or missing, the audio should not start playing automatically.

[aviraldg]

That was intentional, not all clients may wish to respect that hint.

On Thu 23 Jun, 2016, 9:28 PM Kegsay, [email protected] wrote:

In event-schemas/schema/m.room.message#m.audio
#310 (comment):

@@ -37,6 +37,10 @@
"duration": {
"type": "integer",
"description": "The duration of the audio in milliseconds."

•                    },
  

•                    "autoplay": {
  

•                        "type": "boolean",
  

•                        "description": "Hint that the audio should start playing automatically."
  

Be explicit please.

If true, this indicates that the audio should start playing
automatically. If false or missing, the audio should not start playing
automatically.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/matrix-org/matrix-doc/pull/310/files/7660ffbc7ff76a3f4dbf7a677489c8819332ab5c#r68262297,
or mute the thread
https://github.com/notifications/unsubscribe/AAOlRKWWjbNTOvOFk37OjT_zT3a2EUG2ks5qOq0bgaJpZM4IGApw
.

[kegsay]

I understand that not all clients may wish to (given it is a "hint"). That's why you say SHOULD rather than leave it ambiguous.

[kegsay]

Do typing notifications even support arbitrary keys?

[dreamflasher]

Is there any update on this?

[matrixbot]

Can one of the admins verify this patch?

[bawNg]

The lack of push to talk support is one of the biggest things holding matrix back right now compared to proprietary competitors like Discord.

[aviraldg]

There is now a work in progress implementation at matrix-org/matrix-react-sdk#690, so we might want to make a decision here.

[ara4n]

"Activity" sounds like a presence thing to me - we already have currently_active etc there on the presence API. I think it's fine to call this a "typing event" still, but have the special case for a recording notification.

[ara4n]

@aviraldg i think the last question was from our side (@kegsay's review discussion from #310 (comment)) if you can address that :)

Otherwise, modulo the comment I just added, this LGTM

[aviraldg]

@ara4n I believe I updated the language to address @kegsay's concerns?

[kegsay]

@aviraldg : You don't handle the missing case (if there is no autoplay, should it start playing automatically), and you don't use RFC-style SHOULD or SHOULD NOT keywords to indicate playability, you just use the more casual "should".

[aviraldg]

Ah, thanks for explaining. I'll update it accordingly.

On Tue 14 Feb, 2017, 4:19 PM Kegsay, ***@***.***> wrote: @aviraldg <https://github.com/aviraldg> : You don't handle the missing case (if there is no autoplay, should it start playing automatically), and you don't use RFC-style SHOULD or SHOULD NOT keywords to indicate playability, you just use the more casual "should". — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#310 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOlRD5q3qNvS2I6SN39xw8vjKgWrY6oks5rcYajgaJpZM4IGApw> .

-- Regards, Aviral Dasgupta

[Luraktinus]

any news on this?

[turt2live]

This conflicts pretty badly with the spec as it stands today. Like other PRs, this one looks to have been before its time - an MSC for this change would be appreciated. Thanks for the PR in any case!