-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receipts: Add thread_id
to the /receipt
endpoint
#1261
Conversation
It seems to have been omitted in matrix-org#1255 Signed-off-by: Kévin Commaille <[email protected]>
d82135f
to
174fcf2
Compare
Signed-off-by: Kévin Commaille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, thanks for catching! We'll get this included in a patch release.
The changes overall look fairly sane to me. The error code description felt like a run-on sentence, so I've suggested making it a list (while also relaxing the language a bit).
Co-authored-by: Travis Ralston <[email protected]>
hmm, this seems to be missing signoff on all the commits - @zecakeh are you able to provide it? |
Signed-off-by: Kévin Commaille [email protected] Is this enough? |
it is! Thank you. |
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in #1255 Signed-off-by: Kévin Commaille <[email protected]> * changelog Signed-off-by: Kévin Commaille <[email protected]> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <[email protected]> Signed-off-by: Kévin Commaille <[email protected]> Co-authored-by: Travis Ralston <[email protected]>
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in matrix-org#1255 Signed-off-by: Kévin Commaille <[email protected]> * changelog Signed-off-by: Kévin Commaille <[email protected]> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <[email protected]> Signed-off-by: Kévin Commaille <[email protected]> Co-authored-by: Travis Ralston <[email protected]>
It seems to have been omitted in #1255.
Per MSC3771.
Preview: https://pr1261--matrix-spec-previews.netlify.app