Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add R30v2 metric to Panopticon. #22

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Add R30v2 metric to Panopticon. #22

merged 4 commits into from
Aug 6, 2021

Conversation

reivilibre
Copy link
Contributor

See matrix-org/synapse#10332 for the Synapse implementation.

reivilibre added 2 commits July 7, 2021 11:56
@reivilibre
Run go fmt
e257d1c 
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
@reivilibre
Add R30v2
dfe1114
@reivilibre reivilibre self-assigned this Jul 7, 2021
@reivilibre reivilibre marked this pull request as ready for review July 8, 2021 15:32
@neilisfragile neilisfragile self-requested a review July 13, 2021 17:05
neilisfragile
neilisfragile approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@neilisfragile neilisfragile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. There is an ongoing question on how the tests should work since the idea is to ensure backwards compatibility, but I think that is out of scope for this PR and what you have done makes sense.
LGTM

@reivilibre reivilibre merged commit de7435a into master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilisfragile neilisfragile neilisfragile approved these changes

Assignees

@reivilibre reivilibre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reivilibre @neilisfragile