Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stripping empty, optional field device_one_time_keys_count during initial sync breaks Element Android encryption #10456

Closed
anoadragon453 opened this issue Jul 22, 2021 · 2 comments · Fixed by #10457
Closed

Stripping empty, optional field device_one_time_keys_count during initial sync breaks Element Android encryption #10456

anoadragon453 opened this issue Jul 22, 2021 · 2 comments · Fixed by #10457
Labels
S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@anoadragon453
Copy link
Member

#10214 (released in Synapse v1.38.0) removes optional keys from /sync responses if they're an empty value. This can cause the current Element Android release to fail to set up encryption properly after an initial sync, which breaks encryption support. This leads to many unable to decrypt errors, which have started popping up again in reports (i.e element-hq/element-android#1721).

The plan is for Synapse to introduce this field again to fix the current version of Element Android, while allowing some time for a fixed Element Android to be released and for people to update.
@anoadragon453 anoadragon453 added S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 22, 2021
@anoadragon453
Copy link
Member Author

Issue on the Element Android side: element-hq/element-android#3725

dbkr added a commit that referenced this issue Jul 22, 2021
@dbkr
Always send device_one_time_keys_count
ae717dc 
As per comment

Fixes #10456
See also element-hq/element-android#3725
@dbkr dbkr mentioned this issue Jul 22, 2021
Merged
4 tasks
@anoadragon453 anoadragon453 linked a pull request Jul 22, 2021 that will close this issue
Always send device_one_time_keys_count #10457
Merged
4 tasks
erikjohnston pushed a commit that referenced this issue Jul 22, 2021
@dbkr
Always send device_one_time_keys_count (#10457)
7da24b9 
As per comment

Fixes #10456
See also element-hq/element-android#3725
@anoadragon453
Copy link
Member Author

This is fixed by #10457, which is present in Synapse v1.38.1 and v1.39.0rc2. This issue affects Synapse v1.38.0 and v1.39.0rc1. Please upgrade if you are affected.

@erikjohnston erikjohnston mentioned this issue Jul 26, 2021
Closed
5 tasks
@anoadragon453 anoadragon453 mentioned this issue Jul 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always send device_one_time_keys_count matrix-org/synapse
1 participant
@anoadragon453