Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Re-introduce "Leave out optional keys from /sync" #9941

Closed
2 tasks done
callahad opened this issue May 6, 2021 · 5 comments · Fixed by #10214
Closed
2 tasks done

Re-introduce "Leave out optional keys from /sync" #9941

callahad opened this issue May 6, 2021 · 5 comments · Fixed by #10214
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases

Comments

@callahad
Copy link
Contributor

callahad commented May 6, 2021 •
edited
Loading

The changes from #9919 were backed out in #9940 as it broke notifications on Element iOS.

We should re-introduce #9919 as soon as we're able.

Blockers:
@callahad callahad added P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases labels May 6, 2021
@callahad callahad mentioned this issue May 6, 2021
Merged
@richvdh
Copy link
Member

richvdh commented May 6, 2021

I think we should set a target on doing this work, otherwise it's never going to happen.

@manuroe: I'm going to assume it is realistic that we will be able to do this in three months (ie, by 6th August). Please let us know if you think that is too ambitious.

@manuroe
Copy link
Contributor

manuroe commented May 6, 2021

The fix will be available in the release we will make in 2 weeks. 95% of people update their app within 1 week.

@deepbluev7
Copy link
Contributor

Also related: element-hq/hydrogen-web#343 matrix-nio/matrix-nio@6097f2c

Although those are merged already at least.

@deepbluev7
Copy link
Contributor

FTR, this is now fixed in iOS. Not released yet though.

matrix-org/matrix-ios-sdk#1100

@tulir
Copy link
Member

tulir commented Jun 18, 2021

The release seems to have hit app store 9 days ago, so I guess 95% of people should have updated by now. Can we get this into 1.37? :3

@anoadragon453 anoadragon453 mentioned this issue Jun 18, 2021
Merged
@pixlwave pixlwave mentioned this issue Jun 19, 2021
Merged
@erikjohnston erikjohnston mentioned this issue Jul 26, 2021
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-introduce "Leave out optional keys from /sync" change matrix-org/synapse
5 participants
@callahad @richvdh @tulir @manuroe @deepbluev7