Update SDK to v0.19.0 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK now includes a dependency on SwiftyBeaver that can't be found. Adding as a Swift Package seems to fix it but this seems like it should be no more than a temporary workaround. 😬
|
Positives: Launching Nio seems to be wayyyy faster now! 🚀 |
kloenk
reviewed
Jul 27, 2021
| @@ -81,6 +81,15 @@ | |||
| "revision": "36ecf80429d00a4cd1e81fbfe4655b1d99ebd651", | |||
| "version": "0.1.2" | |||
| } | |||
| }, | |||
| { | |||
| "package": "SwiftyBeaver", | |||
There was a problem hiding this comment.
SwiftyBeaver is a new dependency introduces by MatrixSDK?
There was a problem hiding this comment.
Yep. It’s the first swift framework dependency on the SDK, but I couldn’t figure out how to get the xcframework to include the module interface for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update includes fixes to handle optional keys that will no longer be returned from Synapse once the fix for matrix-org/synapse#9941 is merged. For element-ios it sounds like it only broke notifications, but probably good to get this merged fairly quickly in case anything else gets upset.
CAVEATS: The SDK now includes a dependency on SwiftyBeaver which is the first Swift dependency for the framework. This has broken our binary package as the modulemap doesn't get included and I'm not even sure if (or how to check) the .a is included within the framework. So far the only workaround I've found is to add SwiftyBeaver as a Swift Package dependency on NioKit which sounds like a terrible idea to me but it worked 🤷♂️.
Warnings and/or other suggestions definitely welcome 😊