Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Comment about a better future where we can get the state diff between two events #13586

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Comment about a better future where we can get the state diff between two events #13586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e4e10a
Comment about a better future where we can get the state diff between…
MadLittleMods Aug 22, 2022
ec44d79
Add changelog
MadLittleMods Aug 22, 2022
52a7d18
Link relevant issue
MadLittleMods Aug 24, 2022
2781885
Use actual room alias
MadLittleMods Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13586.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Comment about a better future where we can get the state diff between two events.
8 changes: 8 additions & 0 deletions synapse/handlers/federation_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,14 @@ async def _get_state_ids_after_missing_prev_event(
InvalidResponseError: if the remote homeserver's response contains fields
of the wrong type.
"""

# It would be better if we could query the difference from our known
# state to the given `event_id` so the sending server doesn't have to
# send as much and we don't have to process as many events. For example
# in a room like #matrix:matrix.org, we get 200k events (77k state_events, 122k
# auth_events) from this call.
#
# Tracked by https://github.com/matrix-org/synapse/issues/13618
(
state_event_ids,
auth_event_ids,
Expand Down