Simplify our serialization logic #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
force-pushed
the
simpler-pickling
branch
from
0ba70b7 to
2e641eb
Compare
poljar
force-pushed
the
simpler-pickling
branch
3 times, most recently
from
4d6c33a to
fa562a8
Compare
dkasak
reviewed
Feb 15, 2022
poljar
force-pushed
the
simpler-pickling
branch
from
fa562a8 to
c0a0c83
Compare
poljar
force-pushed
the
simpler-pickling
branch
from
c0a0c83 to
6390ad7
Compare
dkasak
requested changes
Feb 28, 2022
There was a problem hiding this comment.
Left a bunch of comments. In the interest of getting this out as soon as possible, if any of my suggestions here are hard to do right now, I think the only critical thing is the boxing of Curve25519SecretKey. The rest can be done in a separate clean up PR if need be.
Co-authored-by: Denis Kasak <[email protected]>
dkasak
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of types in our serialization logic seem to be of questionable usage. We should revise our serialization logic and where possible remove helper structs and use serde directly, this include error types.