Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for blank placeholder spaces. #316

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

xrolfex
Copy link
Contributor

@xrolfex xrolfex commented Jan 30, 2024

This PR adds support for a new object type of placeholder. It offers a way to put in blank spaces to allow for custom layouts.

This is one way to address #313. It still needs localization and is a first attempt. Im not sure if this is how you would like to handle it.

image image image image image image

@matt8707
Copy link
Owner

Looks good. It's somewhat related to sidebar > divider > empty option. So, it would be nice to maintain consistency in appearance. However, this could lead to confusion with "new object". So maybe that style but gray in color, what do you think?

divider

@xrolfex
Copy link
Contributor Author

xrolfex commented Jan 31, 2024

So something more like this? Are you also thinking remove the placeholder text as well?

image

@matt8707
Copy link
Owner

Yeah I'm thinking,

  • Make it transparent white to differentiate from the yellow
  • Use $lang('empty') instead of 'placeholder' (unsure if needed)
  • Internally, rename it to 'empty'

@xrolfex
Copy link
Contributor Author

xrolfex commented Feb 1, 2024

Yeah I'm thinking,

  • Make it transparent white to differentiate from the yellow
  • Use $lang('empty') instead of 'placeholder' (unsure if needed)
  • Internally, rename it to 'empty'

Got these taken card of; did remove the text during editing:

image

src/lib/Main/Empty.svelte Outdated Show resolved Hide resolved
src/lib/Modal/EmptyConfig.svelte Outdated Show resolved Hide resolved
xrolfex and others added 2 commits February 1, 2024 04:08
@xrolfex
Copy link
Contributor Author

xrolfex commented Feb 1, 2024

Requested changes applied.

@matt8707 matt8707 merged commit 92a22f8 into matt8707:main Feb 1, 2024
@xrolfex xrolfex deleted the feature/placeholder branch February 1, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants