refactor: remove context.done and replace with object return

Continues work started in probot#18
mattcan · Nov 5, 2020 · f469c60 · f469c60
1 parent 796e0a1
commit f469c60
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/index.js b/index.js
@@ -65,10 +65,10 @@ module.exports.serverless = appFn => {
 
     // Bail for null body
     if (!event.body) {
-      return context.done(null, {
+      return {
         statusCode: 400,
         body: 'Event body is null.'
-      })
+      }
     }
 
     // Do the thing

diff --git a/tests/index.test.js b/tests/index.test.js
@@ -49,10 +49,8 @@ describe('serverless-lambda', () => {
       }
     }
 
-    await handler(event, context)
-    expect(context.done).toHaveBeenCalledWith(null, expect.objectContaining({
-      statusCode: 400
-    }))
+    const result = await handler(event, context)
+    expect(result.statusCode).toBe(400)
     expect(spy).not.toHaveBeenCalled()
   })