Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

remove experiments that fail to compile on new nightly #28

Closed
wants to merge 1 commit into from

Conversation

joonazan
Copy link

@joonazan joonazan commented Jan 5, 2024

Removes the module "experiments" because nobody is using it and it breaks compilation.

Copy link
Member

@shamatar shamatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks depend on them, otherwise I'd remove them immediately

@joonazan
Copy link
Author

joonazan commented Jan 5, 2024

In that case we can compile this module only for benchmarks, rather than having it be public and always compiled like now. Why do benchmarks need simd when the actual code doesn't, though?

@shamatar
Copy link
Member

shamatar commented Jan 5, 2024

They do not, but baseline non-vectorized ops are there

@shamatar
Copy link
Member

shamatar commented Jan 5, 2024

I disabled benchmarks in another PR, just use "main"

@shamatar shamatar closed this Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants