Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add windows bat scripts for unit tests #186

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

antonbaliasnikov
Copy link
Contributor

What ❔

Add .bat copies of .sh scripts for std::process::Command in solc CLI tests.

Why ❔

The Command module is unable to execute any script that doesn't have the .bat or .cmd extension on Windows regardless of its correctness.
For more info: rust-lang/rust#94743

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (98a7ce2) to head (86fe709).
Report is 1 commits behind head on az-tests-for-solc-errors.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           az-tests-for-solc-errors     #186   +/-   ##
=========================================================
  Coverage                     60.67%   60.67%           
=========================================================
  Files                           129      129           
  Lines                         15397    15397           
=========================================================
  Hits                           9342     9342           
  Misses                         6055     6055           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonbaliasnikov
Copy link
Contributor Author

@hedgar2017 , you usually don't like macros usage, should I rewrite to multiple constants here? It was too much boilerplate.

@hedgar2017
Copy link
Collaborator

@hedgar2017 , you usually don't like macros usage, should I rewrite to multiple constants here? It was too much boilerplate.

This kind of macro is fine, thanks! :)

@hedgar2017 hedgar2017 merged commit bb7cd71 into az-tests-for-solc-errors Oct 29, 2024
14 checks passed
@hedgar2017 hedgar2017 deleted the aba-add-windows-scripts branch October 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants