-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699
Conversation
…/github todo" command (#36)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 15.78% 15.92% +0.13%
==========================================
Files 15 15
Lines 5574 5583 +9
==========================================
+ Hits 880 889 +9
Misses 4652 4652
Partials 42 42
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and Approved
All the links are reflected well and redirecting the user correctly to the desired page, LGTM.
Summary
The URL that was used to create the pretext of the unread message and the repo URL was missing in the body of Discussion and CheckSuite type unread. We updated the code to use the repo link present in the body of an unread message. Also, we couldn't find any possible way to get the URL of "Discussion" or "CheckSuite", so we are not displaying them as a link.
Screenshots
Earlier:
Now:
Possible risk:
What to test:
/github todo
command are rendered and working properly.Steps to reproduce
/github todo
command in any MM channel.Environment:
MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0
Ticket Link
Fixes #693