-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-51310 Implement OAuth2 Authentication (reopened) #949
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
==========================================
- Coverage 31.16% 29.88% -1.29%
==========================================
Files 50 52 +2
Lines 7409 7734 +325
==========================================
+ Hits 2309 2311 +2
- Misses 4909 5231 +322
- Partials 191 192 +1
☔ View full report in Codecov by Sentry. |
@mickmister @DHaussermann Fixed issue: Comment webhook notification not working in the following PR because I didn't have the access to push the code in this PR: #953 |
🥳 2 more to go to make work easier again! 😄 |
Any update on when this issue will be resolved? |
…h2 and Added PKCE code for OAuth2 (#953) * Migrate Docs from GitBook (#948) * Migrate Docs from GitBook * Update readme.md * Update readme.md Co-authored-by: Katie Wiersgalla <[email protected]> * Update readme.md Co-authored-by: Katie Wiersgalla <[email protected]> * Update readme.md Co-authored-by: Katie Wiersgalla <[email protected]> --------- Co-authored-by: Katie Wiersgalla <[email protected]> * [MI-3153] Fixed issue: comment webhook notification not working * [MI-3153] Added PKCE along with authorization code for getting the access token * [MI-3153] Review fixes * [MI-3159] Review fixes of comments given by Kshitij * [MI-3159] Review fixes given by Ayush * [MI-3159] Removed the code which was forcing the template window to close after user is connected * [MI-3153] Review fixes * [MI-3159] Review fixes * [MI-3159] Review fix * [MI-3282] Added logic to expand issue and issue with DM notification for comment webhook notification (#58) * [MI-3282] Added logic to expand issue in comment webhook notification * [MI-3282] Fix lint errors * [MI-3315] Fixed issue: comment DM notification not working due to invalid API call * [MI-3282] Review fixes * [MI-3282] Review fix * [MI-3331] Review fixes on PR #953 (Comment notification issue) (#60) * [MI-3331] Review fixes on PR #953 (Comment notification issue) * [MI-3331] Added separate condition to check if the instance is a cloud instance or not * [MI-3335] Review fixes on Jira PR #953(Comment notification issue) (#62) 1. Added conditional for separation out the logic for jira cloud and server --------- Co-authored-by: Carrie Warner (Mattermost) <[email protected]> Co-authored-by: Katie Wiersgalla <[email protected]>
@mickmister What are the next steps on this PR? Is it ready for QA testing? |
@hanzei Yes it's ready for QA testing. Discussing in Brightscout channel next steps for testing https://community.mattermost.com/core/pl/ng4tz8stp7ynucq7bgrp9edj7y |
Tested and approved, LGTM
|
@DHaussermann It seems the Jira comment events are fixed now. Merging the PR, and we can cover any more regression testing in the release testing. |
Summary
Reopening of #928
This PR implements the OAuth2 authentication in the Jira Plugin.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-51310
Screenshots
Install OAuth2 using setup flow
Whenever the system admin runs the command
/jira setup
, the setup flow to configure OAuth2 client would look something like this: