Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-954]:Fixed issue 'DM comment notifications not working' #961

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

  • Fixed the issue that users were not getting DM notifications when they are mentioned in a Jira issue comment.
  • Updated the code to replace the jira username or email address with mattermost username.

Issue

…rking' (#61)

* [MI-3338]:Fixed issue mattermost#954 'DM comment notifications not working'

* [MI-3338]:Fixed CI
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.01% 🎉

Comparison is base (1766506) 31.16% compared to head (68184a9) 31.17%.

❗ Current head 68184a9 differs from pull request most recent head 0ec335e. Consider uploading reports for the commit 0ec335e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   31.16%   31.17%   +0.01%     
==========================================
  Files          50       50              
  Lines        7409     7409              
==========================================
+ Hits         2309     2310       +1     
+ Misses       4909     4904       -5     
- Partials      191      195       +4     
Files Changed Coverage Δ
server/utils.go 20.35% <62.50%> (+2.65%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/utils.go Outdated Show resolved Hide resolved
server/webhook_http_test.go Outdated Show resolved Hide resolved
* [MI-3337]:Fixed review comment of PR mattermost#961 and added TC

* [MI-3337]:Added EOF
* [MI-3337]:Fixed review comment of PR mattermost#961 and added TC

* [MI-3337]:Added EOF

* [MI-3337]:Fixed review comments of mattermost#961
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 8, 2023
@mickmister mickmister requested a review from DHaussermann August 8, 2023 21:13
@mickmister
Copy link
Contributor

@DHaussermann Heads up that this is a customer reported issue. LGTM ready for QA review

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Aug 17, 2023
@AayushChaudhary0001
Copy link

Tested and approved, LGTM

  • This issue is tested on MM version-7.8.2 and Jira version-9.
  • The comment notification in DM's seems to be working fine on mentioning any particular user.
  • On changing the username and renaming it similar to the email ID, the comment notifications in DM's are working as per the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users mentioned in Jira comment are not receiving DM notifications for Jira 9.2
5 participants