[GH-240]:Fixed issue #240 edited the pretext of custom post #287

Kshitij-Katiyar · 2023-02-28T07:52:21Z

Summary

Users could not edit the post's pretext message for starting a new zoom meeting due to a hardcoded message.
This PR contains all the changes from Pr #248 So this PR alone is enough to fix this issue so we can close Pr #248 afterward.

Issue

mattermost-build · 2023-02-28T07:52:30Z

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov · 2023-02-28T19:33:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f50692b) 19.33% compared to head (582b298) 19.33%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   19.33%   19.33%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          286      286           
  Misses       1138     1138           
  Partials       55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mickmister · 2023-02-28T19:36:18Z

webapp/src/components/post_type_zoom/post_type_zoom.jsx

@@ -79,7 +79,7 @@ export default class PostTypeZoom extends React.PureComponent {
        let content;
        let subtitle;
        if (props.meeting_status === 'STARTED') {
-            preText = 'I have started a meeting';
+            preText = post.message;


Note that these are originally set by

mattermost-plugin-zoom/server/http.go

Line 287 in c3533e3

post.Message = "The meeting has ended."

and

mattermost-plugin-zoom/server/http.go

Line 287 in c3533e3

post.Message = "The meeting has ended."

hanzei · 2023-03-09T12:04:54Z

/update-branch

mattermost-build · 2023-03-09T12:04:56Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

… into MM-240

Kshitij-Katiyar · 2023-03-09T13:00:44Z

/update-branch

@hanzei synced with master

mattermost-build · 2023-03-09T13:00:46Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

mattermost-build · 2023-03-20T01:01:53Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-10-10T07:31:32Z

@AayushChaudhary0001 Can you please review this PR?

AayushChaudhary0001

@hanzei @Kshitij-Katiyar Tested this PR, working fine for text messages, but not supporting emoji's and GiF's if added in the message

mickmister · 2023-10-13T05:01:34Z

To render the markdown using the webapp's markdown logic, we can use the webapp's exposed functions formatText and messageHtmlToComponent

https://github.com/mattermost/mattermost-plugin-ai/blob/6f5c45ccbf3bb262fb6710bdc6a08838ff47e5cc/webapp/src/components/post_text.tsx#L43-L47

    const text = messageHtmlToComponent(
        formatText(props.message, markdownOptions),
        true,
        messageHtmlToComponentOptions,
    );

    return (
        <div>
            {text}
        </div>
    );

avas27JTG · 2023-10-26T12:15:00Z

@hanzei @Kshitij-Katiyar Tested this PR, working fine for text messages, but not supporting emoji's and GiF's if added in the message

@AayushChaudhary0001 this has been fixed.

AayushChaudhary0001

Tested and approved
Working fine for emoji's and reactions, LGTM!

hanzei · 2023-10-27T12:43:34Z

@Kshitij-Katiyar Please merge master into your PR

…m into MM-240

[MI-2825]:Fixed issue mattermost#240 edited the pretext (#5)

03e623a

Kshitij-Katiyar requested a review from larkox as a code owner February 28, 2023 07:52

larkox requested a review from mickmister February 28, 2023 09:32

larkox approved these changes Feb 28, 2023

View reviewed changes

mickmister approved these changes Feb 28, 2023

View reviewed changes

mickmister added the 3: QA Review Requires review by a QA tester label Feb 28, 2023

mickmister requested a review from DHaussermann February 28, 2023 19:36

Merge branch 'master' of github.com:mattermost/mattermost-plugin-zoom…

f5ef9ce

… into MM-240

mattermost-build added the Lifecycle/1:stale label Mar 20, 2023

hanzei requested a review from AayushChaudhary0001 October 10, 2023 07:31

hanzei removed the Lifecycle/1:stale label Oct 10, 2023

AayushChaudhary0001 reviewed Oct 10, 2023

View reviewed changes

hanzei removed the request for review from DHaussermann October 16, 2023 20:39

hanzei added the Awaiting Submitter Action Blocked on the author label Oct 16, 2023

[MM-240]: Added support to render post markdown.

1932718

avas27JTG requested a review from AayushChaudhary0001 October 26, 2023 12:14

avas27JTG removed the Awaiting Submitter Action Blocked on the author label Oct 26, 2023

AayushChaudhary0001 approved these changes Oct 27, 2023

View reviewed changes

hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 27, 2023

hanzei added this to the v2.0.0 milestone Oct 27, 2023

Merge branch 'master' of github.com:Brightscout/mattermost-plugin-zoo…

582b298

…m into MM-240

avas27JTG merged commit a44bfe7 into mattermost:master Oct 27, 2023
9 checks passed

avas27JTG deleted the MM-240 branch October 27, 2023 14:00

This was referenced Oct 31, 2023

[MI-3689]: Test cases of Zoom PR #284 and #287 Brightscout/mattermost-test-management#9

Merged

Added test cases of Zoom settings slash command and edit meeting message. mattermost/mattermost-test-management#125

Open

This was referenced Nov 14, 2023

Bump version v2.0.0 (closed, renamed to v1.7.0) #321

Closed

Bump version v1.7.0. #322

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-240]:Fixed issue #240 edited the pretext of custom post #287

[GH-240]:Fixed issue #240 edited the pretext of custom post #287

Kshitij-Katiyar commented Feb 28, 2023

mattermost-build commented Feb 28, 2023

codecov bot commented Feb 28, 2023 •

edited

Loading

mickmister Feb 28, 2023

hanzei commented Mar 9, 2023

mattermost-build commented Mar 9, 2023

Kshitij-Katiyar commented Mar 9, 2023

mattermost-build commented Mar 9, 2023

mattermost-build commented Mar 20, 2023

hanzei commented Oct 10, 2023

AayushChaudhary0001 left a comment •

edited by Kshitij-Katiyar

Loading

mickmister commented Oct 13, 2023

avas27JTG commented Oct 26, 2023

AayushChaudhary0001 left a comment

hanzei commented Oct 27, 2023

[GH-240]:Fixed issue #240 edited the pretext of custom post #287

[GH-240]:Fixed issue #240 edited the pretext of custom post #287

Conversation

Kshitij-Katiyar commented Feb 28, 2023

mattermost-build commented Feb 28, 2023

codecov bot commented Feb 28, 2023 • edited Loading

Codecov Report

mickmister Feb 28, 2023

Choose a reason for hiding this comment

hanzei commented Mar 9, 2023

mattermost-build commented Mar 9, 2023

Kshitij-Katiyar commented Mar 9, 2023

mattermost-build commented Mar 9, 2023

mattermost-build commented Mar 20, 2023

hanzei commented Oct 10, 2023

AayushChaudhary0001 left a comment • edited by Kshitij-Katiyar Loading

Choose a reason for hiding this comment

mickmister commented Oct 13, 2023

avas27JTG commented Oct 26, 2023

AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

hanzei commented Oct 27, 2023

codecov bot commented Feb 28, 2023 •

edited

Loading

AayushChaudhary0001 left a comment •

edited by Kshitij-Katiyar

Loading