-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test cases for extra check on API of TODO plugin #114
base: main
Are you sure you want to change the base?
Added test cases for extra check on API of TODO plugin #114
Conversation
* [MI-3533]: Added test cases for extra check on API of ToDO plugin * [MI-3533]: Review fixes * Review fix Co-authored-by: kshitij katiyar <[email protected]> --------- Co-authored-by: kshitij katiyar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AayushChaudhary0001 ,
Wonderful to see you pushing a test cases PR.
I am wondering if you feel we should Add End-2-End scenarios as tests cases that can later be automated as well, rather than API tests as currently described in PR.
Would you be comfortable to add scenarios that a User might face when using the plugin.
Example: Plugin Setup, different Commands, user scope.
@AayushChaudhary0001 Heads up that CI is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AayushChaudhary0001 The test scripts seem fine to me but as Ben mentioned there is a failing check.
- 0/5
Edit issue.md
has a space in the file name unlike he others which have an underscore but that may not be impactful in any way. - Not sure why the check is failing but have you tried running
deno task validate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folder: ToDo | ||
authors: "@AayushChaudhary0001" | ||
team_ownership: | ||
- Change Team Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AayushChaudhary0001 , please add team name
name: "Accept Todo" | ||
status: Active | ||
priority: Normal | ||
folder: ToDo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the folder name will be API
.
Also, make the folder name in small case plugins/todo/api
.
Summary
This PR contains the test cases for extra check on API of Todo Plugin
Test coverage for the following API's:-
PR link(for which test cases are added):-mattermost-community/mattermost-plugin-todo#209