-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the test cases for no webhook added on the Github side and overwritten subscriptions on MM. #153
Open
arush-vashishtha
wants to merge
2
commits into
mattermost:main
Choose a base branch
from
Brightscout:github_subscriptions1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−0
Open
Added the test cases for no webhook added on the Github side and overwritten subscriptions on MM. #153
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
data/test-cases/plugins/github/subscriptions/Update_subscription.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
--- | ||
# (Required) Ensure all values are filled up | ||
name: "Overwrite the existing subscriptions to a github repo or organization in MM channel" | ||
status: Active | ||
priority: Normal | ||
folder: Subscriptions | ||
authors: "@arush-vashishtha" | ||
team_ownership: [] | ||
priority_p1_to_p4: P2 - Core Functions (Do core functions work?) | ||
|
||
# (Optional) | ||
location: null | ||
component: null | ||
tags: [] | ||
labels: [] | ||
tested_by_contributor: null | ||
|
||
# (Optional) Test type and tools | ||
cypress: null | ||
detox: null | ||
mmctl: null | ||
playwright: null | ||
rainforest: [] | ||
manual_test_environments: [] | ||
|
||
# Do not change | ||
id: null | ||
key: null | ||
created_on: null | ||
last_updated: null | ||
case_hashed: null | ||
steps_hashed: null | ||
--- | ||
|
||
**Step 1** | ||
|
||
1. Enter the slash command `/github subscriptions add <repo/organization> --features <features>` and create subscription to a repository or organization in the desired channel or DM/GM on MM. | ||
2. Overwrite the created subscriptions with the slash command `/github subscriptions add <repo/organization> --features <features>` in the same desired channel or DM/GM on MM. | ||
|
||
**Expected** | ||
|
||
The user should be able to view the message and verify the newly added subscriptions along with the previously added subscriptions which got overwritten in the desired channel or DM/GM on MM. |
42 changes: 42 additions & 0 deletions
42
data/test-cases/plugins/github/subscriptions/Webhook_check.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,42 @@ | ||||||
--- | ||||||
# (Required) Ensure all values are filled up | ||||||
name: "An ephemeral post in the chat when the webhook is not found on the github side." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
status: Active | ||||||
priority: Normal | ||||||
folder: Subscriptions | ||||||
authors: "@arush-vashishtha" | ||||||
team_ownership: [] | ||||||
priority_p1_to_p4: P2 - Core Functions (Do core functions work?) | ||||||
|
||||||
# (Optional) | ||||||
location: null | ||||||
component: null | ||||||
tags: [] | ||||||
labels: [] | ||||||
tested_by_contributor: null | ||||||
|
||||||
# (Optional) Test type and tools | ||||||
cypress: null | ||||||
detox: null | ||||||
mmctl: null | ||||||
playwright: null | ||||||
rainforest: [] | ||||||
manual_test_environments: [] | ||||||
|
||||||
# Do not change | ||||||
id: null | ||||||
key: null | ||||||
created_on: null | ||||||
last_updated: null | ||||||
case_hashed: null | ||||||
steps_hashed: null | ||||||
--- | ||||||
|
||||||
**Step 1** | ||||||
|
||||||
1. Remove the existing webhook if present for any desired repository or organization on Github. | ||||||
2. Create a subscription to the desired repository or organization using the slash command `/github subscribe add <repository or organization> --feature <feature>` in the desired channel or DM/GM on MM. | ||||||
|
||||||
**Expected** | ||||||
|
||||||
The user will get an ephemeral message regarding `no webhook was found for the desired repository or organization` along with the successfull subscription message in the desired channel or DM/GM on MM. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.