Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic #40

Merged
merged 2 commits into from
May 21, 2022
Merged

Add Arabic #40

merged 2 commits into from
May 21, 2022

Conversation

abdnh
Copy link
Contributor

@abdnh abdnh commented Oct 31, 2021

This adds a minimal Arabic stemmer based on https://github.com/MihaiValentin/lunr-languages/blob/master/lunr.ar.js

I originally wrote this for use with mdBook. It's not a full port of the JS implementation, as I found many things in the original code to make search quality worse for my use case. If there is a requirement to be fully compatible with lunr-languages, I think I can work on a full port sometime.

@mattico
Copy link
Owner

mattico commented Nov 8, 2021

Are you using a modified version of the JS code to execute the searches as well?

@abdnh
Copy link
Contributor Author

abdnh commented Nov 8, 2021

@mattico
Copy link
Owner

mattico commented Nov 16, 2021

So that's a bit tricky because I don't think it makes sense to support generating search indexes that can't be used. We need to at least point to a compatible JS implementation for people to use for each language.

I think what we should actually do is to include the JS in this repository so that we are free to modify it and can run integration tests. Upstream elasticlunr is basically unmaintained at this point, so I suppose we should do it. I'll try to work on this soon.

@mattico mattico merged commit c37db5c into mattico:master May 21, 2022
@mattico
Copy link
Owner

mattico commented May 21, 2022

Sorry for the wait!

I'm going to release a 3.0.0 version with our suggested JS included in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants