Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header clicked on day in month view #722

Closed
agilob opened this issue Sep 11, 2018 · 3 comments · Fixed by #892
Closed

Header clicked on day in month view #722

agilob opened this issue Sep 11, 2018 · 3 comments · Fixed by #892

Comments

@agilob
Copy link
Contributor

agilob commented Sep 11, 2018

Is your feature request related to a problem? Please describe

Week view has dayHeaderClicked, but month view doesn't.

Describe the solution you'd like

I would like to select all days in a column, by getting a callback from the header cell which contains days [Monday, Tuesday, ...]

Describe your use case for implementing this feature

User would like to create events on every Monday until 2 years from now, clicking on day header should provide a feedback which day was clicked. dayHeaderClicked is available in week view, but month view doesn't have it, implementation looks inconsistent. Callback would return integer, 0 for Sunday, 6 for Saturday = consistent with settings excludeDays: number[] = [0, 6];

@mattlewis92
Copy link
Owner

This sounds like a reasonable request, would you like to make a make a pull request?

@agilob
Copy link
Contributor Author

agilob commented Sep 13, 2018

I don't have time right now for it, but I'll give it a shot in several days if it's still open 👍
I need this functionality in our product to decrease technical debt, so sooner or later I'll do it.

@mattlewis92
Copy link
Owner

I finally had time to finish and release 0.27, thanks for your contribution! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants