-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weekView): Allow drag outside calendar view #214
Conversation
Allow Y axis drag; Set dragData; Remove dragStart event : no need to validate where the event is dragged to; Remove dragSnapGrid because outside the calendar we should be able to drag where we want; Remove validateDrag : no need to valide for external dragndrop
Allow events to be dragged from the calendar view to a drop zone
Thanks for this! Rather than removing the old functionality can we retain the existing behaviour and have this opt in via an option like |
@mattlewis92 It's done. What do you think ? |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 96.99% 97.04% +0.05%
==========================================
Files 30 30
Lines 565 576 +11
Branches 45 49 +4
==========================================
+ Hits 548 559 +11
Partials 17 17
Continue to review full report at Codecov.
|
@ElieSauveterre I've tweaked the logic so that if a user drags the event outside of the calendar view the event start and end dates are always changed by a fixed number of days rather than using the start and end of the week - what do you think? |
@mattlewis92 That's better. Thanks. |
Released as 0.16.0, thanks for the contribution! 👍 |
External events can be drag'n'drop from the calendar view to a drop zone