Start a constants package for defining param/result names. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts to encapsulate some of the parameter and result naming conventions we will make use of to duck-type tasks and pipelines into a common package that the various utilities may draw from. These values are not (yet) set in stone, as I'm hopeful that we can migrate them to use the reverse-DNS style (with some support in Tekton), to better avoid collisions. Related: tektoncd/pipeline#3590
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 4 4
Lines 227 227
=======================================
Hits 126 126
Misses 65 65
Partials 36 36 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to encapsulate some of the parameter and result naming
conventions we will make use of to duck-type tasks and pipelines
into a common package that the various utilities may draw from.
These values are not (yet) set in stone, as I'm hopeful that we can
migrate them to use the reverse-DNS style (with some support in
Tekton), to better avoid collisions.
Related: tektoncd/pipeline#3590