Don't unref _tee - we don't hold reference to this object, it is owned... #8416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need to go into Stable_V4.0 as well? Keep in mind that stable is branched now. |
|
Yes, it would be good to have that in Stable_V4.0 too. Should I submit separate PR for 4.0? |
|
@andrewvoznytsa Yes can you submit a PR against Stable_V4.0 as well |
|
@andrewvoznytsa I"m trying to get stable wrapped up right now so I asked @dogmaphobic to cherry pick this across to Stable_V4.0 for me. So it should be all good. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by _pipeline
Need to slow down a bit - overlooked double free. This patch fixes issue introduced by #8406