Replaced not equal operator for double values to qFuzzyCompare #8555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DonLakeFlyer Does it make sense? |
|
Yes and no. The reason being is that gimbal yaw is a user entered value. A fuzzy compare tends to important when real numbers are being put through some sort of calculation. And then the outputs of those calculations are compared. Also the gimbal yaw values the user can enter are limited to no decimal places. So theoretically this makes some amount of sense, but in reality it doesn't matter. The largest agrument is around consistency, which I do agree with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using != operator is not a way to go for comparing double values. Moreover, qFuzzyCompare is already widely used in the file, so the fix would be good for keeping consistency too.