-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan: VTOL landing pattern #8645
Conversation
Once this goes in I could use testing on this from VTOL people. |
@DonLakeFlyer I tested it in SITL a bit. Really cool feature, this improves VTOL usability a lot!
|
@sfuhrer Thanks for testing.
It depends on your point of view. I think either is correct. The Heading dispalyed is from Loiter to Land. And Landing Distance is is in relationship to both points.
Some people like dragging some dont. For example changing just the heading by typing allows you to keep the same exact landing distance you had before. Whereas dragging affects both heading and distance which may or may not be what you want. |
exactly. Although there was a recent change to FW Landing Pattern to only let the dragging effect the heading, not distance. This is important to FW as there is a minimum landing distance based on glideslope and loiter altitude (and a few other parameters). It sounds like VTOL also has it's own set of constraints for backtransition. You should think about if you want VTOL Landing Pattern to have a locked distance for dragging or if you are okay with users screwing it up constantly (speaking from experience here ;-) ) Another approach could be for QGC to have a minimum drag distance that was somehow set in the app settings. |
Yeah I wasn't sure if that was needed or not. I think it depends on this:
If there is a standard distance from loiter to land distance which will work in most cases and it's important that distance doesn't get smaller than that default then locking the distance during drag would be a good thing. I don't know enough about VTOL to say yes or no to that. |
@Antiheavy good point about the min distance from loiter to land. For VTOL this is not as crucial as for FW, but still important. And I guess in a product you would even want to fix the distance and only add the possibility to change the heading. |
Exactly. Solvling the offline problem correctly is way beyond a small change. Hence they need to be fixed values, but can be settings as Todd points out. If someone can tell me what they think the default land distance for VTOL is I can put it in. I would make it work this way:
Let's get this part worked out and the we can move on to Todd's suggestion for user configurable settings for these things. |
@DonLakeFlyer your suggestions make total sense. I would put 50m as min distance and 100m as default. |
@DonLakeFlyer Can I please confirm how this works? I'm fairly sure, but this is a bit of a discussion.
|
Correct. MC is expensive battery wise. So it is better to drop altitude in FW mode. It also is important with respect to creating a landing sequence which begins with DO_LAND_START. This allows you to abort a landing a do it over again if needed.
The sequence is: DO_LAND_START, stop photo/video, LOITER_TO_ALT, VTOL_LAND
Set the location of the landing point to be the current vehicle location.
Set the heading from loiter to land to the current vehicle heading. Set to vehicle location/heading are handy to use to match your landing pattern to physical field locations/dimension/wind. Also note: All of these answers apply to FW Landing Pattern item as well. |
Added new VTOL Landing Pattern complex item:
There is an issue somewhere I can't find asking to set FW Landing Pattern heading to match the heading set on takeoff climbout. Under the assumption climbout was set to go into the wind. I would think the same thing applies to VTOL Landing Pattern loiter to land path. Once I figure out how to do that this will happen for VTOL as well.
Related to #8639