Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve category log menu #8679

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Apr 21, 2020

  • Add Set all button
  • Add search category

Video: https://streamable.com/0k4gf9

@DonLakeFlyer
Copy link
Contributor

Love the search. But don't see whan anyone would ever use Set All?

@patrickelectric
Copy link
Member Author

Well, we never know, at least is an option.

@DonLakeFlyer
Copy link
Contributor

I'd rather not have it there. The reason is that I spend a lot of time asking people to turn on various logging options to debug things remotely. I've had many cases where folks then do this from the command line and don't do what I ask and just turn on all logging. Which then makes it next to impossible for me to find the information I'm looking for. Making this too easy from the UI will likely make that problem for me even worse. If you really, really need to do that you can still do it from the command line.

@patrickelectric
Copy link
Member Author

@DonLakeFlyer "Set all" removed

@patrickelectric
Copy link
Member Author

Ping

@DonLakeFlyer
Copy link
Contributor

If you put all of this inside the flickable it will work much better on small screens like phones. Those just don't have much vertical real estate to devote something which sticks on the top.

Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric
Copy link
Member Author

@DonLakeFlyer done

@DonLakeFlyer DonLakeFlyer merged commit 98f3431 into mavlink:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants