Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use quick-xml instead of xml-rs #123

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Use quick-xml instead of xml-rs #123

merged 1 commit into from
Aug 22, 2022

Conversation

Erk-
Copy link
Contributor

@Erk- Erk- commented Aug 18, 2022 •
edited
Loading

Since XML-rs is for the time being unmaintained1, and have been
marked as such in RUSTSEC2. I have ported the XML parsing to
quick-xml.

Supersedes #107

Footnotes

  1. https://github.com/netvl/xml-rs/issues/221 ↩

  2. https://rustsec.org/advisories/RUSTSEC-2022-0048 ↩

@Erk- Erk- marked this pull request as draft August 19, 2022 07:19
@Erk- Erk- marked this pull request as ready for review August 19, 2022 07:29
patrickelectric
patrickelectric requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, I would recommend to check and test the CI in your own fork. Right now I need to approve the CI in the repository everytime that you update the PR.

@Erk-
Copy link
Contributor Author

Erk- commented Aug 22, 2022

CI is failing, I would recommend to check and test the CI in your own fork. Right now I need to approve the CI in the repository everytime that you update the PR.

Seems it was only the fmt, it looks to get through CI now at least https://github.com/fusion-engineering-forks/rust-mavlink/runs/7946114295

@Erk- Erk- requested a review from patrickelectric August 22, 2022 09:19
patrickelectric
patrickelectric reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Erk-, please squash the commits for better organization before we merge to the master branch.

@Erk-
use quick-xml instead of xml-rs
0b6bd51 
Since XML-rs is for the time being unmaintained[^1], and have been
marked as such in RUSTSET[^2]. I have made ported the XML parsing to
quick-xml.

[^1]: netvl/xml-rs#221

[^2]: https://rustsec.org/advisories/RUSTSEC-2022-0048
@Erk- Erk- force-pushed the valdemar/quick-xml branch from d031bb2 to 0b6bd51 Compare August 22, 2022 11:45
@Erk- Erk- requested a review from patrickelectric August 22, 2022 11:45
@patrickelectric patrickelectric merged commit 3ea2434 into mavlink:master Aug 22, 2022
@Erk- Erk- mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric Awaiting requested review from patrickelectric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erk- @patrickelectric