Add "practice missed words" mode #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\## Motivation
Monkeytype has the possibility of training just the words that you miss
and this seems like a straight forward thing to add.
\## Implementation
Main change is to add a mssed_words item to the Result struct
```rust
pub struct Results {
pub timing: TimingData,
pub accuracy: AccuracyData,
pub missed_words: Vec<String>,
}
```
And on the Results State, listen for 'p' (practice) to start a new test
from missed words.
```rust
state = State::Test(Test::from_missed_words(&result.missed_words));
```
For the `Results` struct I did a very small refactor in the
`From<&Test>` Trait implementation. I moved the calculation of each
result to its own function, to leave the From function easier to follow.
```rust
Self {
timing: Self::calc_timing(&events),
accuracy: Self::calc_accuracy(&events),
missed_words: Self::calc_missed_words(&test),
}
```
max-niederman
requested changes
Aug 23, 2023
|
Thanks for reviewing my PR and suggesting updates. thanks again for the nice project |
max-niederman
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Monkeytype has the possibility of training just the words that you miss and this seems like a straight forward thing to add.
Implementation
Main change is to add a mssed_words item to the Result struct
And on the Results State, listen for 'p' (practice) to start a new test from missed words.
For the
Resultsstruct I did a very small refactor in theFrom<&Test>Trait implementation. I moved the calculation of each result to its own function, to leave the From function easier to follow.