DefaultDatabaseDirectory changed behaviour

[dugwood]

I've upgraded to 5.x but database has changed its location compared to 4.x. I'm under Linux Debian (stable).

I can see that DefaultDatabaseDirectory has always been /usr/local/share/GeoIP, even for 4.x: https://github.com/maxmind/geoipupdate/blob/v4.11.1/pkg/geoipupdate/defaults_notwin.go#L15

Running install for 4.x:

dpkg -i geoipupdate_4.11.1_linux_amd64.deb
[...]
geoipupdate version 4.11.1
Using config file /etc/GeoIP.conf
Using database directory /usr/share/GeoIP

Switching to 5.x (/etc/GeoIP.conf is exactly the same as for 4.x):

dpkg -i geoipupdate_5.0.2_linux_amd64.deb
[...]
geoipupdate version 5.0.2
Using config file /etc/GeoIP.conf
Using database directory /usr/local/share/GeoIP

Of course you can guess that my configuration has:
# The directory to store the database files. Defaults to /usr/share/GeoIP
# DatabaseDirectory /usr/share/GeoIP

As it's commented out, the default directory changed. As it always have been set to /usr/local/share (in the source code) but in fact used /usr/share when run, to me it's a major change.

I don't know why it happens, perhaps it's in the configuration of the package.

Of course the fix (in my case) is to declare the DatabaseDirectory in /etc/GeoIP.conf

[oschwald]

Thank you for reporting this. This was an unintentional change that broke how the default database directory is set for the rpm and deb builds. I have released 5.0.3 with a fix.