Add geoip user to drop root privileges #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
approved these changes
Jan 18, 2023
|
Thanks! |
oschwald
added a commit
that referenced
this pull request
Jan 18, 2023
|
This is interfering with how we build the Docker images for release and will need to be reverted for the next release. Couldn't you run the image as non-root without this? #142 seems related. |
Merged
oschwald
added a commit
that referenced
this pull request
May 5, 2023
5.1.0 * Fixed the Docker health-check script to use the correct time of the last update attempt. Reported by cford1080. GitHub #225. * Added new `--output` flag to print JSON to standard output describing the result of the run. * Compilation with Go versions before 1.19 is no longer supported. * When using the provided Docker images, `geoipupdate` no longer runs as root in the container. Based on pull request by Andreas Grünenfelder. GitHub #200.
|
After addressing some build issues, a version of your PR was part of the 5.1.0 release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build container without requiring root privileges. Background is we're trying to run it in kubernetes with the restricted PodSecurityStandard policy enforced.