Respect host scheme if set #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
approved these changes
Apr 23, 2024
oschwald
added a commit
that referenced
this pull request
Apr 23, 2024
NajiObeid
added a commit
that referenced
this pull request
Apr 23, 2024
Add change-log item for #310
oschwald
added a commit
that referenced
this pull request
Nov 18, 2024
7.1.0 * Allow the `Host` configuration directive and the `GEOIPUPDATE_HOST` environment variable to accept a value with the scheme set. If not set, it will continue to default to `https://`. Pull request by Gabe Cook. GitHub #310. * Export `HTTPError` to enable fine-grained error handling for users of `github.com/maxmind/geoipupdate/client`. Pull request by Ryan Davis. GitHub #341.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR changes the
Hostconfig andGEOIPUPDATE_HOSTenv to respect the scheme if set. If not set, behavior is unchanged and the scheme will default tohttps://. A nice side-effect is that theurl.Parse()step will cause the host value to be validated during the config load phase. I also updated the docs to reflect that the default value ishttps://, but since it's optional, feel free to let me know if you'd prefer to keep these unchanged.For some background, I have a local Kubernetes job which requires a GeoIP database. I'd prefer to avoid attaching storage for reliability, but I don't want to fetch the database each run. I built an internal service which proxies the GeoIP API and caches the response for a time, and would rather keep communication internal without requiring proxies or HTTPS certificates.
Thank you!