Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to NPM #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Publish to NPM #113

wants to merge 4 commits into from

Conversation

emersion
Copy link
Contributor

Fixes both #112 and #107

@thijstriemstra
Copy link

+1

@mbebenita
Copy link
Owner

👍

@soliton4 it would be great to have an NPM module. This may break the demo, what do you think?

@soliton4
Copy link
Collaborator

@mbebenita would you or anyone mind if i publish a broadway.js under my npm?
https://www.npmjs.com/~sol

@emersion
Copy link
Contributor Author

I already published it at https://www.npmjs.com/package/broadway-player but I can unpublish it if you want to link it to link it to the official repo.

It won't break the live demo as the gh-pages branch is left as is.

@mbebenita
Copy link
Owner

I don't mind, either way. If we start publishing NPM modules it might make sense to document things better and setup some kind of CI so we don't break things.

@amilajack
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants