forked from ARMmbed/mbed-os
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loads of general and MIMXRT-specific test fixes #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/TARGET_EVK/PinNames.h
Show resolved
Hide resolved
...so_MCUS/TARGET_MIMXRT105x/TARGET_EVK/TARGET_1060_EVK/xip/evkbmimxrt1060_flexspi_nor_config.c
Show resolved
Hide resolved
JohnK1987
approved these changes
Jan 1, 2025
multiplemonomials
force-pushed
the
dev/loads-of-test-fixes
branch
from
January 2, 2025 17:29
abf2916
to
8c1bc43
Compare
Base automatically changed from
dev/mimxrt105x-linker-script-use-memory-banks
to
master
January 2, 2025 17:46
Test run pushed here: https://mbed-ce.github.io/mbed-ce-test-tools/tests/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Boy did I have a lot of adventures trying to test my MIMXRT linker script PR. This PR captures all the fixes I had to make to the test suite to get things running smoothly.
Impact of changes
See individual comments for details
One big thing is that I managed to find a workaround (though not a true fix) for #83. I dug into it quite a bit and managed to at least figure out what kind of thing is going on. We shall see if NXP wants to help at all going forward, but at least we have a way to run tests now.
Migration actions required
Documentation
Need to update pyocd upload method docs before merging.
Pull request type
Test results
Working on test run right now...