Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to how target.application-profile works #425

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Jan 19, 2025

Summary of changes

Though I'm glad to have this setting in general, I realized that there are a few tweaks I'd like to make to how it works.

First of all, I thought about it some more, and I really don't think we need the 'auto' option. It's not actually needed in CI because we have the different JSON files we can point it to to select the profile, and I really think the code is simpler without it.

Second of all, I noticed that even when the application profile is full, mbed-baremetal still exists as a CMake target (and is exactly the same as mbed-os). I don't see a super good reason for this and I would rather it not exist in this situation. That way, if you try to do

if(TARGET mbed-baremetal)
    target_link_libraries(foo mbed-baremetal)
endif()

it will actually work as expected!

Impact of changes

  • target.application-profile 'auto' option removed
  • Only one of mbed-os and mbed-baremetal will exist in CMake, depending on the target.application-profile setting.

Migration actions required

Documentation

None (as the auto option was only really used internally, and the documentation states that the default is 'full').


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Copy link

@ccli8 ccli8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it is clean without the auto option, then either mbed-os or mbed-baremetal is created exclusively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants