Tweaks to how target.application-profile works #425
+44
−163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Though I'm glad to have this setting in general, I realized that there are a few tweaks I'd like to make to how it works.
First of all, I thought about it some more, and I really don't think we need the 'auto' option. It's not actually needed in CI because we have the different JSON files we can point it to to select the profile, and I really think the code is simpler without it.
Second of all, I noticed that even when the application profile is
full
,mbed-baremetal
still exists as a CMake target (and is exactly the same asmbed-os
). I don't see a super good reason for this and I would rather it not exist in this situation. That way, if you try to doit will actually work as expected!
Impact of changes
Migration actions required
Documentation
None (as the auto option was only really used internally, and the documentation states that the default is 'full').
Pull request type
Test results