Add abort as coverage criteria #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
changed the title
mbj
force-pushed
the
add/abort-kill-criteria
branch
4 times, most recently
from
7e1f349 to
d9c88d8
Compare
mbj
force-pushed
the
add/abort-kill-criteria
branch
from
d9c88d8 to
170e8dd
Compare
mbj
commented
Nov 23, 2020
| def process_abort? | ||
| process_status = isolation_result.process_status or return false | ||
|
|
||
| !timeout? && !process_status.exited? |
There was a problem hiding this comment.
The reason to not check for abnormal process exits on timeouts, is that on timeouts mutant causes an abnormal exit by itself via sending the process a SIGKILL.
Timeouts are a separate coverage criteria, hence "shadow" the result from being eligible from abnormal process exit coverage criteria.
mbj
commented
Nov 23, 2020
| # | ||
| # @return [Boolean] | ||
| def process_abort? | ||
| process_status = isolation_result.process_status or return false |
There was a problem hiding this comment.
There is a noop isolation (used for debugging) that does NOT create a process status, hence we have to have this branch.
I wish we had a type system to cover all this cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix #1054]