feat: add chrono feature
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv9vats
approved these changes
Apr 18, 2024
|
Hey @mbrobbel, just wondering how much more (maybe unrelated) plumbing is left to allow revisiting this :) |
Not much, I'll try to get to this soon. |
|
Thank you for the work on this. I'm also waiting for this, and would be happy to pick this up if it would help |
If you want to help, please see #165 for more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logical array support for
chronotypes:DateTime<Utc>,NaiveDateTimeandNaiveTime.This does not include generics to control the different logical types supported by Arrow, and it also doesn't map to parquet temportal logical types yet. This needs more work (see #183).
Part of #165.