feat: Implement IntoIterator for FixedSizeListArray
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
force-pushed
the
fixed-size-list-into-iter
branch
from
cff8d09 to
1e1f004
Compare
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
from
1e1f004 to
5530fff
Compare
dhruv9vats
changed the title
IntoIter for FixedSizeListArrayIntoIter for FixedSizeListArray
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
5 times, most recently
from
e387c1a to
3667169
Compare
dhruv9vats
commented
May 19, 2024
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
2 times, most recently
from
d6b33de to
1053044
Compare
dhruv9vats
changed the title
IntoIter for FixedSizeListArrayIntoIterator for FixedSizeListArray
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
3 times, most recently
from
36abc5c to
9c2d974
Compare
dhruv9vats
commented
May 20, 2024
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
from
5bfe6a7 to
cd8d65e
Compare
mbrobbel
reviewed
May 21, 2024
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
from
eb2f997 to
a1a059f
Compare
dhruv9vats
commented
May 21, 2024
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
5 times, most recently
from
dff0949 to
fc9d3c4
Compare
dhruv9vats
changed the title
IntoIterator for FixedSizeListArrayIntoIterator for FixedSizeListArray
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
from
fc9d3c4 to
0605dc3
Compare
mbrobbel
approved these changes
May 23, 2024
auto-merge was automatically disabled
May 24, 2024 06:56
Head branch was pushed to by a user without write access
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
from
0605dc3 to
4cab197
Compare
Add a struct whose iterator yields rust arrays of fixed size (supplied as a const generic `usize`)
Implement consuming `IntoIterator` for `FixedSizeListArray` by using `FixedSizeArrayChunks` and update tests.
dhruv9vats
force-pushed
the
fixed-size-list-into-iter
branch
from
4cab197 to
924a9df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
IntoIteratorforFixedSizeListArrayby introducing aFixedSizeArrayChunkstruct that yields an iterator with items being (fixed size) arrays of the supplied iterator's items.