Skip to content

Commit

Permalink
fix: temporarily skip spurious test failure
Browse files Browse the repository at this point in the history
We have a task in the queue to address the various test failures caused
by live data changing, and in the meantime this frequently blocks other
tasks for no good reason.
  • Loading branch information
digitalcora committed Mar 12, 2021
1 parent 2b303e9 commit d2c6e47
Showing 1 changed file with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -332,18 +332,17 @@ defmodule AlertProcessor.ServiceInfoCacheTest do
assert {:ok, nil} = ServiceInfoCache.get_parent_stop_id(pid, "garbage")
end

# Skipped: This function exists only to support ferry routes, and the test fails when the
# specified Charlestown ferry trip is not running on the current day. All ferry service is
# canceled as of 2020-03-16 due to COVID-19 service changes, but even during regular service,
# this fails when the current day is not a weekday.
@tag :skip
# TODO: address these tests having a dependency on live data that changes frequently

@tag skip: "fails when the current day is not a weekday"
test "get_generalized_trip_id", %{pid: pid} do
assert {:ok, "Boat-F4-Boat-Charlestown-11:45:00-weekday-1"} ==
ServiceInfoCache.get_generalized_trip_id(pid, "Boat-F4-1145-Charlestown-Weekday")

assert {:ok, nil} = ServiceInfoCache.get_generalized_trip_id(pid, "garbage")
end

@tag skip: "fails every time commuter rail trips change"
test "get_trip_name", %{pid: pid} do
assert {:ok, "1801"} = ServiceInfoCache.get_trip_name(pid, "CR-Weekday-Winter-21-1801")
end
Expand Down

0 comments on commit d2c6e47

Please sign in to comment.