[GitHub][PR Decoration] Private Sonarqube server static images unavailable #130
Labels
bug
Something isn't working
Comments
|
I guess a partial revert of #81 is needed to reintroduce the property I removed? |
|
I have the same problem. The problem arises because the my sonarqube server is 'http' and github is 'https'. |
Yeah, looks like that.. |
mc1arke
pushed a commit
that referenced
this issue
May 17, 2020
Some ALMs (such as Github) proxy images in Pull Request decoration and therefore need direct access to the images. If the Sonarqube server isn't internet facing, the ALM will not be able to retrieve the images, and they therefore wont be visible on the Pull Request. This change restores the property for allowing Sonarqube administrators to define the URL for retrieving images, with the images defaulting to loading from the Sonarqube if the property is not set/overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Github uses
https://camo.githubusercontent.com/to proxy any user images on their side and this cannot be disabled. It means every image should be available for GitHub proxy server, which is impossible with the way of serving static images #80 for private hosted Sonarqube server behind a strict firewall.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Static images are available in GitHub PR checks for private and public accessible Sonarqube servers
Screenshots
If applicable, add screenshots to help explain your problem.
Software Versions
Additional context
Please return back function of
com.github.mc1arke.sonarqube.plugin.branch.image-url-baseand make it optional or provide other way to solve this issue.The text was updated successfully, but these errors were encountered: