Bugfix: #201 could not decorate gitlab merge request #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2020
mc1arke
requested changes
Jul 22, 2020
...a/com/github/mc1arke/sonarqube/plugin/server/pullrequest/ws/action/SetBindingActionTest.java
Outdated
Show resolved
Hide resolved
PiekJ
force-pushed
the
bugfix/201-could-not-decorate-gitlab-merge-request
branch
5 times, most recently
from
884b625 to
4fc9569
Compare
|
I resolved your comment about the star import and squashed my commits. Edit: I'll rebase the other PR's when this one got merged. |
PiekJ
force-pushed
the
bugfix/201-could-not-decorate-gitlab-merge-request
branch
from
4fc9569 to
db04a2c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mc1arke
requested changes
Jul 26, 2020
...hub/mc1arke/sonarqube/plugin/server/pullrequest/ws/action/gitlab/SetGitlabBindingAction.java
Outdated
Show resolved
Hide resolved
...hub/mc1arke/sonarqube/plugin/server/pullrequest/ws/action/gitlab/SetGitlabBindingAction.java
Outdated
Show resolved
Hide resolved
PiekJ
force-pushed
the
bugfix/201-could-not-decorate-gitlab-merge-request
branch
from
db04a2c to
e01a8e1
Compare
Fixed setting the project id on sonarqube project pull decorate option when selecting GitLab. When project id is set use that instead of the sonarqube scanner property. Fixed always evaluating fetching sonarqube scanner property for instance url.
PiekJ
force-pushed
the
bugfix/201-could-not-decorate-gitlab-merge-request
branch
from
e01a8e1 to
6030eed
Compare
|
I resolved the suggestions. |
|
Merged. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables GitLab merge request to be decorated. This PR fixes issue #201 for SonarQube 8.2+.