Skip to content

Commit

Permalink
fix: fix clover file level metrics in deploy reports
Browse files Browse the repository at this point in the history
  • Loading branch information
mcarvin8 committed Dec 22, 2024
1 parent b6cceb7 commit cddded4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,11 @@ and this format for Clover:

```xml
<?xml version="1.0" encoding="UTF-8"?>
<coverage generated="1734733618708" clover="3.2.0">
<project timestamp="1734733618708" name="All files">
<coverage generated="1734898566028" clover="3.2.0">
<project timestamp="1734898566028" name="All files">
<metrics statements="62" coveredstatements="54" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0" elements="62" coveredelements="54" complexity="0" loc="62" ncloc="62" packages="1" files="2" classes="2"/>
<file name="AccountTrigger" path="packaged/triggers/AccountTrigger.trigger">
<metrics statements="62" coveredstatements="54" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0"/>
<metrics statements="31" coveredstatements="27" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0"/>
<line num="52" count="0" type="stmt"/>
<line num="53" count="0" type="stmt"/>
<line num="59" count="0" type="stmt"/>
Expand Down Expand Up @@ -359,7 +359,7 @@ and this format for Clover:
<line num="27" count="1" type="stmt"/>
</file>
<file name="AccountProfile" path="force-app/main/default/classes/AccountProfile.cls">
<metrics statements="62" coveredstatements="54" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0"/>
<metrics statements="31" coveredstatements="27" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0"/>
<line num="52" count="0" type="stmt"/>
<line num="53" count="0" type="stmt"/>
<line num="59" count="0" type="stmt"/>
Expand Down
10 changes: 0 additions & 10 deletions src/helpers/setCoveredLinesClover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,4 @@ export async function setCoveredLinesClover(
fileObj.line.push(coveredLineObj);
}
}

// Update Clover file-level metrics
fileObj.metrics['@statements'] += coveredLines.length + uncoveredLines.length;
fileObj.metrics['@coveredstatements'] += coveredLines.length;

// Optionally calculate derived metrics
fileObj.metrics['@conditionals'] ??= 0; // Add default if missing
fileObj.metrics['@coveredconditionals'] ??= 0;
fileObj.metrics['@methods'] ??= 0;
fileObj.metrics['@coveredmethods'] ??= 0;
}

0 comments on commit cddded4

Please sign in to comment.