Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin Cython to < 3.0 #86

Closed
wants to merge 1 commit into from

Conversation

ChrisBarker-NOAA
Copy link

Cython 3.0 is still in beta, but it has quite a few changes, so this should be pinned to less than 3.0 until it can be tested there,

And then it should probably be pinned to >= 3.0

Cython 3.0 is still in beta, but it has quite a few changes, so this should be pinned to less than 3.0 until it can be tested there,

And then it should probably be pinned to >= 3.0
@EpicWink
Copy link
Contributor

Building accelerate with Cython v3.0a11 produces a package which passes the test suite. Up to you whether you want to constrain Cython. In any case, I would avoid the alpha releases of Cython regardless.

@ChrisBarker-NOAA
Copy link
Author

Nice!

I agree that building with a pre-release is not a good idea -- I did this 'cause on a project of mine, Cyton 3 breaks a fair bit -- so I didn't think it should be used without testing. The trick is that when 3.0 comes out as a proper release, then builds will automatically start using it.

But if it works with Cython 3, then we probably don't need to constrain.

I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants